Use gradient bio_ik solver and fix memory issues#705
Merged
Conversation
Flova
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the inverse kinematics solver to use a gradient descent approach and simplifies vector initialization in spline functions to address memory concerns.
- Updated kinematics configuration across multiple groups by adding the "gd_c" mode.
- Refactored the vector initializations in both position and pose spline functions to inline constructions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bitbots_robot/wolfgang_moveit_config/config/kinematics.yaml | Added "gd_c" mode to several kinematics groups to enable gradient descent-based IK. |
| bitbots_motion/bitbots_splines/src/Spline/position_spline.cpp | Simplified getPos, getVel, and getAcc functions with inline vector initializations. |
| bitbots_motion/bitbots_splines/src/Spline/pose_spline.cpp | Refactored spline functions for position and orientation to use shorthand vector construction. |
jaagut
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It doesn't really change anything, but it could be a bit more reliable for our setup, which does not include many local minima.
I also fixes an vector init that was reported as risky by valgrind during the visit at the WF Wolves.
Proposed changes
Use gradients instead of particle swarm optimization in ik.
Related issues
Checklist
colcon build